search

msimet / Stile

Stile: the Systematics Tests In Lensing pipeline
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

#4 #40

Closed dr-guangtou closed 8 years ago

dr-guangtou commented 9 years ago

Now HistogramSysTest.HistoPlot accepts either a numpy ndarray or a list of ndarray as input, and will overplot the histograms together is multiple datasets are provided.

Weighted-histogram is also allowed.

gaussian_test_1 gaussian_test_2 gaussian_test_3

msimet commented 9 years ago

Hi Song, looks great! I'll try to go through the code soon. Thanks!

msimet commented 9 years ago

Also, I just merged our master branch back into this branch, to make sure it had all the changes we've made since you started your work here.

msimet commented 9 years ago

OK, I just left a bunch of comments on this (sorry!). This looks really good--it's nice to have so many customization options. Thanks for putting it together, and finding the AstroML stuff.

msimet commented 9 years ago

Just realized I forgot to mention--I pushed a small commit with some typo fixes. Please see if all the changes are OK with you!

msimet commented 9 years ago

Hi Song, I just merged the new version of master into this branch, so you should pull the changes before you make any edits. (It doesn't affect your code, but it will make sure you can merge cleanly later.)

msimet commented 9 years ago

Hey, sorry for the long delay! This is looking much better--I had a couple of further comments, but not many...

msimet commented 9 years ago

Hi @dr-guangtou, any chance you'll be able to look at this sometime soon? We'd like to include histogram tests in our first-year HSC processing, so it would be nice to get this included in the master branch.

dr-guangtou commented 9 years ago

@msimet Hi! Sorry...have not checked github for some time...what exactly do I need to do?

msimet commented 9 years ago

Hi Song! There are a few comments I had on the code that should be addressed--they show up on this page, put in on April 15. (We also need to merge the master branch back in, but I can do that once you've made the changes--might get a little dicey, I'm not sure what all we've changed since the last time it was done.) They're just little things having to do with the keyword arguments, I think. And once that's done we can merge into master, woohoo!

msimet commented 8 years ago

Hi folks,

This had been sitting open for a while, with just a few tweaks left, so I went ahead and made them. Merging to master now.