#74 Use deepCoadd_meas catalog instead of deepCoadd_src

msimet / Stile

Stile: the Systematics Tests In Lensing pipeline

BSD 3-Clause "New" or "Revised" License

9 stars 6 forks source link

#74 Use deepCoadd_meas catalog instead of deepCoadd_src #76

Closed HironaoMiyatake closed 8 years ago

HironaoMiyatake commented 8 years ago

I added an option to select what type of catalog is used for coadd. The default is deepCoadd_meas, but one could go back to deepCoadd_src by specifying this string in that option.

msimet commented 8 years ago

Hey Hironao, three notes on this before I take a look at it--

You hadn't merged in the latest version of master. I did that. Could you check and see if it looks okay? (8e43960)
This branch also includes branch #60. It would be easier to look at this pull request if we merged that first. I had one question there for you, and if the fix worked we can merge that to master and then merge master here, so it's easier to look at the code.
You also have some things from branch #43. Do you want to do a pull request for that as well, or shall we just do the parts of it included here?

HironaoMiyatake commented 8 years ago

Okay, let's work on #60, and then #43.

HironaoMiyatake commented 8 years ago

I found that #43 was already merged (see PR#62). Sorry that I did not close #43. I'll do that

HironaoMiyatake commented 8 years ago

It works fine. I'll merge this to master.

msimet commented 8 years ago

Whoa, I did not look at this code yet! I wanted to merge the other branches first so I didn't have to look at the changed code in this diff too.

I will look these over later today and make comments then...

msimet commented 8 years ago

Okay--made some comments here. Maybe put any changes on #74 and then merge that branch to master once we've converged?

HironaoMiyatake commented 8 years ago

Sorry that I merged too soon... I updated the code following your comment. If you are comfortable with this change, I'll merge this and #63 to master again.

msimet commented 8 years ago

Thanks! This all looks fine to me, merge when you'd like.