search

msimet / Stile

Stile: the Systematics Tests In Lensing pipeline
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Code review of master + more unit tests #8

Closed msimet closed 10 years ago

msimet commented 10 years ago

I threw a bunch of stuff up on master so we could branch from it, but I'm sure it has errors in it currently.

This issue is for me to write unit tests for the files that currently do not have them (stile_utils.py and tests.py--data_handler.py doesn't currently have anything non-abstract in it). It's also for other people to point out errors with the code as it stands and for me (or volunteers) to fix them.

rmandelb commented 10 years ago

I just tried to update this branch since I made a commit on master for #12 , but there was a conflict with one of the changes from one of the recent PRs. I'm going to leave that to you to resolve (I undid the merge rather than commit anything) but I wanted to point out that that happened. It's probably worth resolving those conflicts before proceeding further with work on here.

msimet commented 10 years ago

Done. (...Yeah, so after reminding everyone else to merge master, I hadn't done it myself...)