#77b Changes to Correlation Functions

msimet / Stile

Stile: the Systematics Tests In Lensing pipeline

BSD 3-Clause "New" or "Revised" License

9 stars 6 forks source link

#77b Changes to Correlation Functions #81

Closed msimet closed 6 years ago

msimet commented 8 years ago

Here's the PR for issue #77, requested changes to the default plotting style and docstring for the CorrelationFunction systematics tests. The changes are, briefly:

Adding units to the x-axis
Adding a horizontal gray line at 0 to aid the eye
Changing xi to xi_re
Extending the docstring to give the correlation function definitions.

I think this is pretty straighforward, but please do check that the docstring makes sense & everything works on your systems!

msimet commented 8 years ago

Hmm. The list of changes here is showing some things from issue #32, but the diff doesn't show them, so I'm not too worried. (I had to do some git rebasing due to accidentally branching off #17, so that's probably why.)

HironaoMiyatake commented 8 years ago

Looks mostly okay. I found that ylabel is cut out from the frame. Do we want to use tight_layout()?

msimet commented 8 years ago

Okay, tried adding this--does it work all right?

HironaoMiyatake commented 8 years ago

Sorry for this late response. Hmm, I do not see ylabel yet... rho1-0009127- 0 3 0 8 1 4 1 8 2 7 2 8 3 8

msimet commented 8 years ago

Hmm, that is annoying! I changed the code to force scientific notation at fewer decimal places--does it look okay now, and do you think those limits are all right?

HironaoMiyatake commented 8 years ago

This looks great now! Sorry for this late reply. Please merge this branch into master.