msink / kotlin-libui

Kotlin/Native interop to libui: a portable GUI library
MIT License
648 stars 49 forks source link

Cleanup gradle setup and generify samples project #14

Closed mervyn-mccreight closed 5 years ago

mervyn-mccreight commented 5 years ago

The general purpose of this branch as to introduce kotlin-multiplatform. Since you have done this already in the meantime, we wanted to share the other changes we did while integrationg kotlin-multiplatform. Below you find a rough summary of what is included.

We tested it on all platforms (windows, linux and macOS) and a clean build as well as building the documentations with dokka worked. We tested all samples by hand and they all seemed to work like before.

We kept the multiple targets, but did not test if it works together with CLion.

msink commented 5 years ago

Well, then I'll check in CLion tomorrow, if it works - will merge as is, if not - merge everything but multiple presets.

mervyn-mccreight commented 5 years ago

Sounds good 👍

If it does not work with CLion we can change it back in our branch, so you do not have to to any extra work and can just 'merge as is'.

msink commented 5 years ago

Does not work: image

You can test it youself - CLion EAP is free (license will expire in a month, but usually there will be next EAP build during that period and license restarts), and Kotlin/Native plugin: https://discuss.kotlinlang.org/t/clion-and-kotlin-native-1-3/10141

msink commented 5 years ago

After (quick and dirty) revert to single preset - it works, so please revert that part for now. Losing compatibility with CLion is major regression.

And, technical question - when merge do you want it save your history or rebased and squashed to single commit?

mervyn-mccreight commented 5 years ago

Sad to hear that it does not work with CLion. We will revert to your single preset approach that is working with CLion.

Thanks for the hint to the EAP 👍

mervyn-mccreight commented 5 years ago

Related to the technical question: In my opinion it would be cool if we can remain the history, so it is easier for others to understand the meaning of lines of code (because it is linked to the commit it has been done).

But if it is easier to squash it, feel free to do so :)

andreas-mausch commented 5 years ago

Hi, we are back to single-target and I've checked code completion with CLion EAP 183.4284.40. Only strange thing I've noticed: All names are the same in the run config dropdown, see screenshot.

bildschirmfoto_2018-11-14_23-01-04

msink commented 5 years ago

All names are the same in the run config dropdown

It's bug in debugger. :)

I'm sure most of these rough edges will be fixed in a month or two, and we can revert to multiple presets. Someday there will be cross-compilation.