search

msjumbu / ilyrics

Automatically exported from code.google.com/p/ilyrics
0 stars 0 forks source link

Updates track lyrics with "Not found" #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Select tracks
2. Select update automatically but not overwrite
3. start the update

What is the expected output? What do you see instead?
The expected out should be either Updated or Missing or Skipped.
What actually happens is all tracks are either Skipped (because they 
already have lyrics - this is okay) or it updates them but for tracks with 
no lyrics on LyricWiki it places the text "Not found" in the lyrics tab of 
the track - very annoying!

What version of the product are you using? On what operating system?
Windows XP, iTunes 8.1, iLyrics 1.1.12 (I think)

Please provide any additional information below.

Original issue reported on code.google.com by williams...@gmail.com on 21 Oct 2008 at 10:42

GoogleCodeExporter commented 9 years ago 
This is happening here too!
Should be easy to fix (i think...)

Original comment by guischm...@gmail.com on 21 Oct 2008 at 5:22

GoogleCodeExporter commented 9 years ago 
amazing...
same problem... even crash, because does not give me any options to continue....
running w/ vista

Original comment by thorfern...@gmail.com on 21 Oct 2008 at 8:52

GoogleCodeExporter commented 9 years ago 
got excatly the same problem :(

Original comment by planet...@gmail.com on 25 Oct 2008 at 2:23

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Hello,

  with the latest source-code I have fixed this issue.

I don't know how to use Google-Code correctly so please keep in mind that I 
have no
idea how to tell that the author!

Ofcause all credits go to him and I have just fixed THIS bug!

When someone want to know how I did that feel free to contact me at 
info@mymartek.de
in English or German.

To install this fix, just copy these files over your iLyrics folder and replace 
old
files(make copies if possible).

Original comment by MarcelWl...@gmail.com on 28 Oct 2008 at 2:00

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Ok, figured this out.  It totally violates basic tenants of set/get functions, 
but
the quick and dirty hack is to replace the 'public string lyrics' in 
References.cs
with this:

        public string lyrics {
            get {
                return this.lyricsField;
            }
            set {
                //begin PRL changes
                if (value == "Not found")
                { 
                    value = ""; 
                }
                //end PRL changes
                this.lyricsField = value;
            }
        }
    }

Original comment by pla...@gmail.com on 9 Nov 2008 at 12:07

GoogleCodeExporter commented 9 years ago 
Thanks, this is fixed in the latest build.

Original comment by mcored on 6 Dec 2008 at 11:38