search

mskcc / LimsRest

the restful service used by the IGO LIMS
2 stars 2 forks source link

Updating isSequencingComplete to use isQcStatusIgoComplete #187

Closed DavidStreid closed 4 years ago

DavidStreid commented 4 years ago

Change: Using isQcStatusIgoComplete to determine if a sample has completed sequencing because it checks whether the data record's PassedQc flag is set to true.

Background: When a sample is marked "IGO-Complete", the method ToggleSampleQcStatus > setSeqAnalysisSampleQcStatus is executed, this modifies both the PassedQc & SeqQCStatus fields of the DataQc record. However, both "Passed" and "IGO-Complete" will have a SeqQCStatus == "Passed" so determining whether sequencing is actually done should be based on whether the PassedQc flag is set to true, which is what the added isQcStatusIgoComplete method does.

mskbot commented 4 years ago

Can one of the admins verify this patch?