mskcc / LimsRest

the restful service used by the IGO LIMS
2 stars 2 forks source link

Handling each exception specifically #199

Closed DavidStreid closed 3 years ago

DavidStreid commented 3 years ago

Removing large try-catch block

ALSO: Removing

            if (existingQc == null) {
                log.info(String.format("Existing %s record not found for Sample with Id %s", SeqAnalysisSampleQCModel.DATA_TYPE_NAME, igoId));
            }

Moving to else condition,

            if (existingQc != null) {
               ...
            }
            else {
                log.info(String.format("Existing %s record not found for Sample with Id %s", SeqAnalysisSampleQCModel.DATA_TYPE_NAME, igoId));
               ...
            }
mskbot commented 3 years ago

Can one of the admins verify this patch?