mskcc / LimsRest

the restful service used by the IGO LIMS
2 stars 2 forks source link

Compare rowIndex and newIgoId #282

Closed apatruno618 closed 2 years ago

apatruno618 commented 3 years ago

Samples within a project should be promoted in 1 event, not in batches. Promoting in batches can cause a series of issues downstream such as assigning an IGO ID that does not correspond with the order the investigator submitted in.

There are cases in which Sample Receiving and Project Management does need to promote at different times so we don't want to prevent this from happening but we should compare rowIndex and newIgoId and return a warning containing a list of samples where the values are not equal.

https://github.com/mskcc/LimsRest/blob/ddd3b4ae4e78674fd2cab490aa61b8a0d0dd11b5/src/main/java/org/mskcc/limsrest/service/PromoteBanked.java#L336