search

mskcc / cwl-commandlinetools

Central location for CWL CommandLineTools
Other
3 stars 3 forks source link

Ss/mksas refactor #20

Closed shalabhsuman closed 5 years ago

shalabhsuman commented 5 years ago

Have updated the dockerfile for Waltz and built the image, however, have not been able to successfully test the Waltz jar within the docker container after running the image. #18

allanbolipata commented 5 years ago

Can you give more info? What have you tried so far? Commands, error logs, etc.

Also, if it doesn't work, we should avoid making pull requests for it. Issues should work fine.

rhshah commented 5 years ago

I second @allanbolipata, @shalabhsuman can you please test this first before doing a pull request to master, also as you started from @ionox0 branch it is also asking for his changes to be merged.

shalabhsuman commented 5 years ago

Did another commit after integrating the edits as per comments above. I thought it would be a good idea to retain the Keys remove memory_overhead, remove memory_per_job & number of threads in the YAML file, but leave their values as NULL. Any idea if the default values from CWL will be used in this case (when the values are NULL inside YAML)??