search

mskelton / ratchet

Codemod to convert React PropTypes to TypeScript types.
https://mskelton.dev/ratchet
ISC License
138 stars 14 forks source link

Added Intuita 1-Click Run #77

Closed mohab-sameh closed 1 year ago

mohab-sameh commented 1 year ago

Added support for running Ratchet using the Intuita VS Code extension. Now you can 1-click run Ratchet using Intuita VSCE on your projects.

This addition allows you to use Intuita's features with Ratchet, such as:

💡 To learn more about the features you can use while running Ratchet with Intuita's VSCE, read the docs here.

mskelton commented 1 year ago

@mohab-sameh This looks great. My only concern is around the language of it. I'm a little concerned that it ties a direct connection between Ratchet and Intuita which could seem to indicate that I'm employed by y'all or something similar. Not that it's necessarily bad or would harm either me or you guys, but it could be a little confusing for users.

Totally fine with it being the first thing before the CLI command, I love what you all are doing and thing it's a great workflow for codemods.

mohab-sameh commented 1 year ago

@mohab-sameh This looks great. My only concern is around the language of it. I'm a little concerned that it ties a direct connection between Ratchet and Intuita which could seem to indicate that I'm employed by y'all or something similar. Not that it's necessarily bad or would harm either me or you guys, but it could be a little confusing for users.

Totally fine with it being the first thing before the CLI command, I love what you all are doing and thing it's a great workflow for codemods.

Totally understandable. It would be great if we could let users know that the codemod is running on a different platform (Intuita) so that they are aware they will be redirected elsewhere. But definitely, we can tone down the branding if you like or put a non-affiliation note. I can change this or feel free to edit it to something you consider acceptable before merging. Thanks a lot for bringing it up @mskelton

mskelton commented 1 year ago

@mohab-sameh Sorry for the delay, busy week for me, but I made a few adjustments to the text and merged this in!

mohab-sameh commented 1 year ago

@mskelton no worries. awesome!