mskg / homey-heating

Heating scheduler for Athom Homey
https://homey-heating.mskg.app/
GNU General Public License v3.0
6 stars 6 forks source link

Virtual thermostat not allways set according to plan #164

Open JOR200 opened 4 years ago

JOR200 commented 4 years ago

Hi @mskg

My virtual thermostats are not always set correctly by the Heating Scheduler according to the belonging plans. The same goes for the Heating scheduler flow card “Apply all active heating plans”. Some virtual thermostats are set correctly and some are not. When I use the heating Schedulers flow card “Apply heating plan” one after another for all my plans, all the virtual thermostats are always set correctly. I wonder if the heating scheduler has issues finding out witch plans are active and witch are not. I had several plans earlier on that were deleted and new ones have been built from scratch. I guess the deleted plans are still in place somewhere, but flagged as deleted? How are the deleted plans handled when a given plan is evaluated as active or not when the scheduler should change setpoints for the virtual thermostat? Is the enumeration of “the living plans” handled correctly?

Rgds.

JOR200 commented 3 years ago

Have you seen this, @mskg ?

JOR200 commented 1 year ago

Hi. This is still an issue for me. Can you please have a look at this? After upgrade to v2.0.6, my workaround (flowcard for Apply heating plan every 5 minutes) actually set the physical thermostats even if they are allready set correctly. I have 2x heat pumps that makes a beep everytime the set points are set. This is quite anoying. I wonder why some of my virtual thermostats does not change according to plan. Any suggestions?

mskg commented 1 year ago

Code hasn't changed at all with respect to that functionality.

There seems to be an issue with reading the values correctly. The underlying SDK from Homey is beta - I need to check if this might be an issue.

JOR200 commented 1 year ago

I have now deleted my virtual thermostats (Plans) and re-added all. I now got the on/off capability and will also check if virtual thermostats are set correctly according to plans.

JOR200 commented 1 year ago

Re-adding the virtual thermostats made no differense.

Can it be some illegal characters in the zone names or room names? Virtual thermostat names or the plans names? Here's how my zones and rooms are set up and named: image

I also wonder why the heating plans (vthermos) can be selected as devices to be controlled by a plan: image

JOR200 commented 1 year ago

Hi @mskg It looks like when a given schedule is handeled all further reading/writing of setpoint values are disabled for 30 minutes. My workaround for the virtual thermostats not beeng set seem to read the setpoint values correctly after 30 minutes. Same thing happends when next schedule schould trigger a setpoint change for a virtual thermostat.

mskg commented 1 year ago

You are genius ;) That is for sure the problem and explains the loops. I have a look at that.

JOR200 commented 1 year ago

Please let me know if you need a diagnostics report or if you want me to to do further testing.

JOR200 commented 1 year ago

I had a look at the other issues reported since upgrade to SDK3. If I move a plan (virtual thermostat) into the same room/zone that is defined in the plan, I have a lot of errors and the plan change to manual. This is for your information.

The 30min disable described earlier has been there since 2020, but now also apply when I use flowcards to apply the heatingplans every 5 minutes. The virtual thermostat (and the physical ones) are then set correctly, but the HeatingScheduler does not know that the thermostats are set.

JOR200 commented 1 year ago

I think a plan schould never try to control itself.