search

mskg / homey-heating

Heating scheduler for Athom Homey
https://homey-heating.mskg.app/
GNU General Public License v3.0
6 stars 6 forks source link

Heat set to 0 degrees #54

Closed vinta7 closed 5 years ago

vinta7 commented 5 years ago

Subject of the issue

The app is picking up the right temperature from the schedule but try to set it to 0 degrees, startet after upgrade to 1.1.2 img_0276

Steps to reproduce

Tell us how to reproduce this issue.

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

mskg commented 5 years ago

The left part until the 16° is produced by the App, the rest by the driver. The app checks the range of temperatures your driver supports, before setting it. Such, if the temperature you request if out of bounds, it chooses the lowest/highest possible value.

I will look at the driver.

vinta7 commented 5 years ago

I have 2 Nest thermostats 3 gen., worked with the beta issues (had to restart the app. some times) until the upgrade, but since yesterday this error.

Regards

Den tir. 19. feb. 2019 kl. 11.52 skrev Markus notifications@github.com:

The left part until the 16° is produced by the App, the rest by the driver. What kind of thermostats do you have?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mskg/homey-heating/issues/54#issuecomment-465083540, or mute the thread https://github.com/notifications/unsubscribe-auth/AtkFZ_c3yum-TebsSIVeVpmNqjUx7rMsks5vO9dagaJpZM4bCnCQ .

mskg commented 5 years ago

Can you create a logfile via console.re? You can simulate what happens by running the ApplyPlans flow.

vinta7 commented 5 years ago

Have never tried it, will have a look at it later

mskg commented 5 years ago

You can also contact me on slack if you like, than we can have a look together.

mskg commented 5 years ago

I looked at the code again and checked relevant places. The temperature set is definitly validated against the device's min/max capability values. It's unclear to me how can this happen. I definitly need logfiles.

mskg commented 5 years ago

Thanks for the logfile, I understood the problem now. The NEST thermostat does not report step size for the target_temperature capability. This leads to

2019-02-19 15:00:08 [log] [g] [INFO ] [AthomAPI ] Target adjusted Bedroom Thermostat (Bedroom Thermostat) was 16 -> NaN (min: 9, max: 32, step: undefined)

2019-02-19 15:00:09 [log] [g] [ERROR] [ST/Check ] Retry action 5 times, waiting for 1000 { (Bedroom Thermostat) Failed to set target temperature to 0, error: Error: TEMPERATURE C VALUE IS TOO LOW: %S: {"error":"Temperature C value is too low: 0.0","type":"https://developer.nest.com/documentation/cloud/error-messages#low-c-value","message":"Temperature C value is too low: 0.0","instance":"52bcf447-2a2d-47d0-9b54-f9b6bdcfb3d7","details":{"tempC":"0.0"}}: (Bedroom Thermostat) Failed to set target temperature to 0, error: Error: TEMPERATURE C VALUE IS TOO LOW: %S: {"error":"Temperature C value is too low: 0.0","type":"https://developer.nest.com/documentation/cloud/error-messages#low-c-value","message":"Temperature C value is too low: 0.0","instance":"52bcf447-2a2d-47d0-9b54-f9b6bdcfb3d7","details":{"tempC":"0.0"}}

To be honest, I didn't expect that to be not set. I will fix this.

mskg commented 5 years ago

Your bug is fixed in the RC for the next version. You can find the latest build here https://github.com/mskg/homey-heating/tree/release/v1.2.0-rc13

Would be great if you drop me a short not if it's fixed there?

Release notes https://github.com/mskg/homey-heating/blob/feature/plan-overview/docs/releasenotes/v01-02-00.md

vinta7 commented 5 years ago

Great job 👍, looks like the isuue has been solvet in rc13

tir. 19. feb. 2019 16.41 skrev Markus notifications@github.com:

Your bug is fixed in the RC for the next version. You can find the latest build here https://github.com/mskg/homey-heating/tree/release/v1.2.0-rc13

Would be great if you drop me a short not if it's fixed there?

Release notes https://github.com/mskg/homey-heating/blob/feature/plan-overview/docs/releasenotes/v01-02-00.md

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mskg/homey-heating/issues/54#issuecomment-465183029, or mute the thread https://github.com/notifications/unsubscribe-auth/AtkFZ1O86Z9BI0uJCjdaJvWOLvJ14yJ1ks5vPBsXgaJpZM4bCnCQ .