search

mskg / homey-heating

Heating scheduler for Athom Homey
https://homey-heating.mskg.app/
GNU General Public License v3.0
6 stars 6 forks source link

Virtual thermostat: wrong mean temperature #93

Closed RonnyWinkler closed 5 years ago

RonnyWinkler commented 5 years ago

Hello Markus,

great app! Thank you for your work.

I found a little bug in the virtual thermostat. Just want to let you know about. If there are 2 davices in the group/plan, the mean temperature is calculated wrong. Only the temperature of one thermostat is devided by the numer od devices th the plan.

Here are screenshots, 1st from the virtual thermostat and the two real devices (Eurotronics Z-Wave).

Screenshot_20190410-203436_Homey Screenshot_20190410-203445_Homey Screenshot_20190410-203453_Homey

Bye Ronny

RonnyWinkler commented 5 years ago

Hello Markus, after a restart of Homey all is ok now. The temperature of the virtual thermostat is the mean value like expected. Don't know what was wrong yesterday.

mskg commented 5 years ago

Let me check the trouble shooting logs the App collects.

aeklo commented 5 years ago

Confirming same issue on v1.2.1. Restart of Homey does not solve the problem in my case.

20190511_123625000_iOS 20190511_123709000_iOS

mskg commented 5 years ago

Yes, there might be an issue related to #96. Homey does not allow creation of listeners (temperature, etc.) of devices that are currently not available. During the startup, there might be an order of execution that results in your behavior.

Could you try:

RonnyWinkler commented 5 years ago

Hello Markus,

yes, that could be right. It seams, the thermostat was not reachable at that time.

I think Homey (or the Eurotronics app) showed up the last known temperature in the device screen. But your app has got „0“ as value. That couel explain the wrong average value.

After a Homey restart, the Z-wave mesh seems to be refreshed and the termostats are online. I also added a Z-wave repeater for mot thermostats on 3 floors. I got no ploblems again.

Thank you for for investigating.

If the error appears again, I will check your suggestion and report the result. But it seams I can’t reproduce without hitting the mesh.

Bye

Ronny

Von: Markus notifications@github.com Gesendet: Samstag, 11. Mai 2019 17:26 An: mskg/homey-heating homey-heating@noreply.github.com Cc: rywr ronny.winkler@web.de; State change state_change@noreply.github.com Betreff: Re: [mskg/homey-heating] Virtual thermostat: wrong mean temperature (#93)

Yes, there might be an issue related to #96 https://github.com/mskg/homey-heating/issues/96 . Homey does not allow creation of listeners (temperature, etc.) of devices that are currently not available. During the startup, there might be an order of execution that results in your behavior.

Could you try:

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mskg/homey-heating/issues/93#issuecomment-491520328 , or mute the thread https://github.com/notifications/unsubscribe-auth/ALZT37WETKYXQ3EBL7DUF3TPU3QPRANCNFSM4HFAECDA .

aeklo commented 5 years ago

Confirming a restart of the app fixes the problem. Restart of Homey does not. Maybe add a confirmation, or re-check, of temp readings in the app then?

mskg commented 5 years ago

Should be fixed by #96, #95. If this is not resolved in 1.2.2 please reopen the issue.