search

mskocik / svelty-picker

Simple date & time picker in svelte
https://mskocik.github.io/svelty-picker/
202 stars 46 forks source link

Library needs to be updated to allow svelte-5 #170

Closed whishkid closed 6 months ago

whishkid commented 6 months ago

In my projected in a test branch i updated to svelte 5.. but I think this library needs some work to prepare.

Should update peer dependencies to "peerDependencies": { "svelte": "^3.53.0 || ^4.0.0 || ^5.0.0" },

But i think you also need to update to latest SvelteKit first

mskocik commented 6 months ago

PeerDependency updated in 5.2.7. I as quickly tested basic functionality it should work.

whishkid commented 6 months ago

Did you run te test project using svelte 5 ? Didnt seem to work for me, but i Have bigger issues with the svelte 5 upgrade, so for now just replaced the datepicker with SHOW DATE HERE :) I am in no hurry to use this for production by the way, but just want to help the svelte team discover any bugs.

mskocik commented 6 months ago

Did you run te test project using svelte 5 ?

Of course 😃 whole library works in dev mode svelte 5, but doesn't build. But it's not related to component itself, but some other dev dependency.

As you can see in this svelte 5 repl, it works. So probably something else is breaking your app and not the svelty-picker itself. But to be honest I haven't done more deep testing myself. So if you find some bugs with this transitional version, let me know.