search

mskyaxl / wsl-terminal

Terminal emulator for Windows Subsystem for Linux (WSL)
MIT License
3.12k stars 158 forks source link

Sometime can't go fullscreen on v0.8.12 #148

Closed feryardiant closed 4 years ago

feryardiant commented 5 years ago

I've been using this project as my daily basis since v0.8.10 and never had any issues whatsoever, but after upgrading to v0.8.12 I've noticed that sometimes I can't go fullscreen using ALT + ENTER keys and don't have idea why it could happened.

The issue is only happened after startup wsl-terminal, anytime I pressed ALT + ENTER it just echoed ^[. But when I started using tmux the ALT + ENTER is works just fine, even I exited tmux.

image

WSL-Terminal v0.8.12 Ubuntu 18.04.2 Shell ZSH 5.4.2 Windows 10 Home 64bit Version 1803 Build 17134.648 TMUX 2.6 with this tmux.conf

feryardiant commented 5 years ago

Today I realized that the issue is only happened when I am using right ALT key while the left ALT key is works just fine. Having tested it multiple times and got the same results, the right ALT+ ENTER isn't working on my machine.

I have tried to rollback to v0.8.11, both left and right ALT + ENTER are working without any issues.

mskyaxl commented 4 years ago

can you please retry on 0.9.0?

feryardiant commented 4 years ago

HI @mskyaxl,

I can confirm that LEFT-ALT + ENTER in v0.9.0 is works just fine. But, RIGHT-ALT + ENTER still remain the same, only have "cleaner" output. I mean, I still can't enter full screen and the ^[ is no longer appears.

I still expecting using both LEFT-ALT & RIGHT-ALT should work the same like v0.8.11 was. All I can do is ask you, is it desired behavior?

Thanks

mskyaxl commented 4 years ago

Thanks! I will try to reproduce it and if I can I will create an issue in mintty repo :)

mskyaxl commented 4 years ago

Hi, @feryardiant , it looks like this issues is aleady covered by https://github.com/mintty/mintty/issues/969

I can reproduce it. I have an US international layout and I have this behavior because the Right-ALT is actually Alt Gr and does nothing.

I will close this - Please follow the mintty topic for further updates. :)

feryardiant commented 4 years ago

Thank you @mskyaxl

Anyway, may I ask, which mintty version you're using on v0.8.10? Is it still using mintty v2.8.4 as stated in v0.8.8 release?