mskyaxl / wsl-terminal

Terminal emulator for Windows Subsystem for Linux (WSL)
MIT License
3.12k stars 160 forks source link

v0.9 Scrolling inside tmux not working as it's used to be #183

Open feryardiant opened 4 years ago

feryardiant commented 4 years ago

How to reproduce

Expected

The text on screen is scrolled as it should be in the previous versions

Actual

It's scrolling command history before actually scrolling text on screen


Tried to roll back to v0.3.13 everything's still works fine Open any file using vim inside tmux, srolling still works fine Tried compared to Windows Terminal

YuRBPhBYCL

mskyaxl commented 4 years ago

Thanks for the detailed report! I will have a look :)

mskyaxl commented 4 years ago

Hi @feryardiant,

I am not able to reproduce or I don't understand the issue completely.

Scroll on TMUX on 0 9 0

How do you start the wsl-terminal? with login?

feryardiant commented 4 years ago

Hi @mskyaxl

Sorry for late reply, here's my wsl-terminal shortcut' property:

C:\tools\lib\wsl-terminal\bin\mintty.exe --wsl --rootfs=// --configdir "C:\tools\lib\wsl-terminal\etc" -i "C:\tools\lib\wsl-terminal\open-wsl.exe"  -t "        " -e /bin/wslbridge2  -e SHELL="/usr/bin/zsh"

and yes I am on login shell

feryardiant commented 4 years ago

Anyway, for some reasons it might be there's some issues with my dotfiles config but I still don't know. I'll do some investigate & let you know once I figured it out.

mskyaxl commented 4 years ago

Hi @mskyaxl

Sorry for late reply, here's my wsl-terminal shortcut' property:

C:\tools\lib\wsl-terminal\bin\mintty.exe --wsl --rootfs=// --configdir "C:\tools\lib\wsl-terminal\etc" -i "C:\tools\lib\wsl-terminal\open-wsl.exe"  -t "        " -e /bin/wslbridge2  -e SHELL="/usr/bin/zsh"

and yes I am on login shell

if zsh is your shell .bashrc will not be sourced at startup

can you try to run <your path>\wsl-terminal\open-wsl.exe -l?

A good read about the order of the *rc files: https://shreevatsa.wordpress.com/2008/03/30/zshbash-startup-files-loading-order-bashrc-zshrc-etc/

feryardiant commented 4 years ago

if zsh is your shell .bashrc will not be sourced at startup

Yes, you're right and I have to admit that I don't really familiar in this regard, lol. But this answer helps me to verify

image

can you try to run <your path>\wsl-terminal\open-wsl.exe -l?

Tried this:

C:\tools\lib\wsl-terminal\bin\mintty.exe --wsl --rootfs=// --configdir "C:\tools\lib\wsl-terminal\etc" -i "C:\tools\lib\wsl-terminal\open-wsl.exe -l"  -t "        " -e /bin/wslbridge2  -e SHELL="/usr/bin/zsh"

Result: image

Tried this:

C:\tools\lib\wsl-terminal\bin\mintty.exe --wsl --rootfs=// --configdir "C:\tools\lib\wsl-terminal\etc" -i "C:\tools\lib\wsl-terminal\open-wsl.exe" -t "        " -e /bin/wslbridge2  -e SHELL="/usr/bin/zsh" -l

I see wslbridge2-backend has --login flag but not the zsh

image

mskyaxl commented 4 years ago

C:\tools\lib\wsl-terminal\bin\mintty.exe --wsl --rootfs=// --configdir "C:\tools\lib\wsl-terminal\etc" -i "C:\tools\lib\wsl-terminal\open-wsl.exe -l" -t " " -e /bin/wslbridge2 -e SHELL="/usr/bin/zsh"

this cannot work because -i argument for mintty is the selection of the icon, try please: C:\tools\lib\wsl-terminal\bin\open-wsl.exe -l and that's all