Readme is out of date on build instructions

mskyaxl / wsl-terminal

Terminal emulator for Windows Subsystem for Linux (WSL)

MIT License

3.12k stars 160 forks source link

Readme is out of date on build instructions #186

Closed cbartondock closed 4 years ago

cbartondock commented 4 years ago

Readme refers to a build.bat which does not exist.

I couldn't get build.sh in scripts to work (sudo ./build.sh and source build.sh don't work), but perhaps I am missing something. Anyway updated build instructions would be nice.

mskyaxl commented 4 years ago

good point:) I'll update them :). But until then feel free to try out pre-packed releases :)

cbartondock commented 4 years ago

Will do ! For the time being I think I have it working. Needed some chmod 777's, some dos2unix commands, and installing cygwin with the Devel packages enabled (I was too lazy to figure out which packages exactly are needed - but definitely make, gcc, and binutils). Waiting for cygwin to finish now

cbartondock commented 4 years ago

Yep! build succeeded. Here's what I needed to do to get it to work:

Install Cygwin 64 and the Devel packages
sudo apt install dos2unix
cd scripts; sudo chmod 777 *.sh; dos2unix *.sh
./build.sh

mskyaxl commented 4 years ago

or you can run clone the repo from wsl and run wsl build.sh :)

cbartondock commented 4 years ago

Inside powershell? Neat! More issues regarding the readme, it doesn't seem to respect changing the default shell to /usr/bin/zsh in wsl-terminal.conf

Is there something else that needs to be done to get it to use the shell I choose?

mskyaxl commented 4 years ago

I have updated the readme :)

cbartondock commented 4 years ago

Nice!