ARM: dts: qcom: apq8026-samsung-milletwifi: Add touchscreen buttons

msm8226-mainline / linux

Mainline Kernel fork for MSM8x26 devices

Other

2 stars 5 forks source link

ARM: dts: qcom: apq8026-samsung-milletwifi: Add touchscreen buttons #10

Closed Susurrus closed 3 months ago

z3ntu commented 6 months ago

Signed-off-by please in the commit message, and add some comment - or indicate if it should be squashed into some other commit next time I rebase.

Susurrus commented 6 months ago

Sorry about that. Didn't realize that's how this should work. I think I annotated this correctly now.

Also, 432ab7333549a41e9f6288d60aeab55bf51d7f3e is a hack, does that also need an annotation? Probably should open an issue here to track it as there's some other context around it I have in my notes too.

Susurrus commented 6 months ago

Note that matisse-wifi uses APPSELECT, so I'm confused which one should be used here. Is there any documentation I can reference here?

z3ntu commented 6 months ago

I'd check what's more commonly used on phones in mainline. Not sure there's docs for input like this, in a similar area there is some docs for the "function" for leds so notification led is defined rather well

Susurrus commented 5 months ago

MENU is way more common. However, I found https://gitlab.com/postmarketOS/pmaports/-/commit/c655f5cc9c4110d4ff118327c52c5c1d4841eeb5 which is weird, that the DTS should have APPSELECT but then pmOS should remap it?

I'm wondering if I should open a general pmOS issue on this or maybe ask in the GNOME Discourse if they have any opinion. WDYT?

z3ntu commented 5 months ago

You could for sure ask in the postmarketOS mainline channel what other people think. My devices don't have these touchkeys (well, apart from OnePlus One I believe but there the touchscreen driver doesn't support the keys yet) so I cannot tell you much there myself.

Susurrus commented 5 months ago

Since I'm using what's most common right now, it's probably fine for the initial bringup work. Any objections from you to merging this as-is?

Susurrus commented 5 months ago

Correct, but I want to test it again before resubmitting.

Susurrus commented 4 months ago

Tested and working. Included in my latest round of upstreaming patches.

z3ntu commented 4 months ago

Tested and working. Included in my latest round of upstreaming patches.

Are you sure? Your v3 on the mailing lists uses this line?

linux,keycodes = <KEY_APPSELECT KEY_BACK>;

https://lore.kernel.org/linux-arm-msm/20240219214643.197116-3-bryant@mai.rs/

Susurrus commented 3 months ago

Whoops, looks like I didn't force-push the changes but had them locally.

However, now that you have a 6.8 branch, should I instead merge this there?

z3ntu commented 3 months ago

Pushed https://github.com/msm8226-mainline/linux/commit/b73ea5a88849d2849056f936e7946e695957c197 to the 6.8 branch now, that should resolve this PR :)