msm8226-mainline / linux

Mainline Kernel fork for MSM8x26 devices
Other
2 stars 5 forks source link

Improve charger support for msm8226 & msm8974 #5

Closed Susurrus closed 9 months ago

Susurrus commented 9 months ago

Default built-in PMIC to "disabled". Enable smb358 charger IC for milletwifi.

Not tested on any other hardware at this point. Any devices that didn't have a smbb node in their own DTS I didn't bother to enable it, so it's possible this introduces a regression for: samsung-matisse-wifi, samsung-matisselte, lge-nexus5-hammerhead, qcom-apq8074-dragonboard.

z3ntu commented 9 months ago

You should enable smbb for qcom-apq8074-dragonboard because that one uses smbb as extcon there https://github.com/msm8226-mainline/linux/blob/qcom-msm8226-6.5.y/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts#L443

The others look fine.

Susurrus commented 9 months ago

Fixed, thanks for the review.

z3ntu commented 9 months ago

Fixed up some stuff but looks fine now :) https://github.com/msm8226-mainline/linux/compare/d1a9d57da2166a8687c2358dcf1ef2df5db8d7b7..9bd52be506fd7815c63897b140b7ef7f7f043d65