search

msm8953-mainline / linux

Linux mainline kernel with WIP patches for msm8953 devices
Other
111 stars 59 forks source link

PMI632 vibrator #109

Closed z3ntu closed 1 year ago

z3ntu commented 1 year ago

A port of the leds-qpnp-vibrator-ldo.c driver from downstream exists at https://github.com/mtvec/msm8953-mainline-linux/tree/fp3-vibrator (HEAD: 86d0a91a66e28f22a110036e3a02a3ae74219491)

@mtvec Since the driver looks pretty clean, do you have a plan of upstreaming this?

mtvec commented 1 year ago

Hi @z3ntu, I would love to upstream this at some point but I currently don't have a device available to test this on. So I don't know when I will have time for this unfortunately.

Feel free to take the code and upstream it yourself if you want it to be done quickly!

z3ntu commented 1 year ago

Could you maybe squash it together and add a Signed-off-by line for the DCO?

Also I assume the functionality worked fine, you didn't have any problem? Anything else I should be aware of?

z3ntu commented 1 year ago

I see there's a patch already on the mailing list from Qualcomm: https://lore.kernel.org/linux-arm-msm/20230731053712.2220898-1-quic_fenglinw@quicinc.com/T/

Not 100% sure though if it covers the same HW block, would need to check as I see no trace of "LDO" in this patch series.