Open z3ntu opened 11 months ago
Imports downstream amplifier driver (which isn't pretty of course, but works...).
Not quite sure how to handle the required
#if 0
inmsm8953.dtsi
I added (which are necessary because FP3 doesn't use wcd_codec). Should we just move this out ofmsm8953.dtsi
into the device dts which do use wcd_codec?If that's resolved, I'll of course rework the commits and make them prettier.
You could override audio-routing and maybe we could add a label for dai-link and than you can delete it with /delete-node/.
I'd mostly say non-common stuff (like the stuff I commented out) just shouldn't be in msm8953.dtsi but should be in device dts or so.
I'd mostly say non-common stuff (like the stuff I commented out) just shouldn't be in msm8953.dtsi but should be in device dts or so.
I understand audio-routing could be moved out because it is different on almost every device, but what about the dai-link many device uses the wcd_codec, i don't really like the approach duplicating stuffs. With a label you could override the sound-dai
property. Or other solution define sound_card node from scratch for FP3.
Imports downstream amplifier driver (which isn't pretty of course, but works...).
Not quite sure how to handle the required
#if 0
inmsm8953.dtsi
I added (which are necessary because FP3 doesn't use wcd_codec). Should we just move this out ofmsm8953.dtsi
into the device dts which do use wcd_codec?If that's resolved, I'll of course rework the commits and make them prettier.