msm8953-mainline / linux

Linux mainline kernel with WIP patches for msm8953 devices
Other
111 stars 59 forks source link

arm64: dts: qcom: msm8953-motorola-potter: use panel from lk2nd #64

Closed nathanjensen1 closed 1 year ago

nathanjensen1 commented 1 year ago

I have two moto g5's with both panel types and have tested that it works correctly on both

z3ntu commented 1 year ago

Please always add your Signed-off-by when submitting patches, see https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

nathanjensen1 commented 1 year ago

Please always add your Signed-off-by when submitting patches, see https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Done

alikates commented 1 year ago

Sure, i didn't merge it yesterday because I expected to rebase and reorder the commits so i didn't forget about it xD

alikates commented 1 year ago

Rebased and merged. Ty!

Tuom commented 1 year ago

Hi @nathanjensen1, I have moto g5 plus XT1685 with Tianma panel. I installed postmarket OS on it but display does not work. I saw that you recently created MR also in lk2nd bootloader about Tianma panel. I tested it with the newest version but with no success. Can you please tell me which model do you have and how did you make it work? Or do you have any clue what can be a problem with my device? Thanks

nathanjensen1 commented 1 year ago

@Tuom The model of my Moto G5 Plus is XT1687. I just checked and the display is still working on mine with the latest lk2nd and postmarketOS Edge. On your phone, can you boot into the lk2nd recovery mode and tell me what it says the panel type is? It should be something like qcom,mdss_dsi_mot_tianma_520_1080p_vid_v0

Tuom commented 1 year ago

@nathanjensen1, thanks for reply. Yes it is exactly that qcom,mdss_dsi_mot_tianma_520_1080p_vid_v0

nathanjensen1 commented 1 year ago

@Tuom Can you ssh into the phone and send me the dmesg output?

Tuom commented 1 year ago

@nathanjensen1 here it is: https://pastebin.com/x3snwBKw

nathanjensen1 commented 1 year ago

@Tuom It looks like you are building your own kernel from one on the 6.3.0-rc2 branches. I just checked and it looks like they accidentally reverted this merge request, and instead have the Boe panel hard coded in the device tree https://github.com/msm8953-mainline/linux/blob/6.3.0/main/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts#L103

Tuom commented 1 year ago

Hmm... I tried to build newest changes of kernel before, but I though that if I run pmbootstrap zap it will revert it... I will try it with normal kernel. Thanks

Tuom commented 1 year ago

@nathanjensen1, thanks a lot. It helped... kind of... Now display does not turn off completely, but shows some log at the beginning, but xfce4 does not show. Only when I reboot the device (via ssh), it show postmarketOS logo and Shutting down...

nathanjensen1 commented 1 year ago

@Tuom If you are getting the display showing the kernel logs and postmarketOS logo, then the panel driver is working. It is likely a userspace issue. You should still be able to drop into a TTY by holding volume down and pressing the power button three times

Tuom commented 1 year ago

@nathanjensen1 I can't get into TTY. Nothing happened after pressing this button combination.

Tuom commented 1 year ago

@nathanjensen1, thank you for your help. I tried multiple user interfaces. Xfce4 does not seems to work at all, but others like plasma mobile do. I can also get into TTY, but touch does not work at all. I don't want to bother you, but do you have any clue what can be a problem?

Here is dmesg, if it helps https://pastebin.com/dZL4HKrh

nathanjensen1 commented 1 year ago

@Tuom [ 16.547790] rmi4_i2c 0-0020: rmi_set_page: set page failed: -6. [ 16.547824] rmi4_i2c 0-0020: Failed to set page select to 0 This is where the touchscreen driver fails to load. I'm having the same issue on mine. I'll see what I can find out

Tuom commented 1 year ago

@nathanjensen1, ok thanks. Please let me know if you find something out or if I can help you somehow.