search

msm8953-mainline / linux

Linux mainline kernel with WIP patches for msm8953 devices
Other
111 stars 59 forks source link

hynix SR556 camera sensor: errors at compile time (6.1.0) #69

Closed M0Rf30 closed 1 year ago

M0Rf30 commented 1 year ago

this should be the offending commit https://github.com/msm8953-mainline/linux/commit/25f6279086277e9087cbcc8f813186258e1f55f9 

drivers/media/i2c/sr556.c:1042:19: error: initialization of 'void (*)(struct i2c_client *)' from incompatible pointer type 'int (*)(struct i2c_client *)' [-Werror=incompatible-pointer-types]
 1042 |         .remove = sr556_remove,
      |                   ^~~~~~~~~~~~
drivers/media/i2c/sr556.c:1042:19: note: (near initialization for 'sr556_i2c_driver.remove')
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:250: drivers/media/i2c/sr556.o] Error 1

@vldly @alikates

z3ntu commented 1 year ago

Update remove method to return void instead of int.

M0Rf30 commented 1 year ago

Solved with latest commits on 6.1.0 branch. thanks