search

msm8953-mainline / linux

Linux mainline kernel with WIP patches for msm8953 devices
Other
111 stars 59 forks source link

arm64: dts: qcom: msm8953: sync edit with upstreamed patchset #75

Closed M0Rf30 closed 1 year ago

M0Rf30 commented 1 year ago

This commit uniforms qcom msm8953 family dts resources

Signed-off-by: Gianluca Boiano morf3089@gmail.com

z3ntu commented 1 year ago

Why are you removing &dsi_phy0? I think that should stay?

Also we should squash this in the next rebase so it just becomes nice patches on top of mainline instead of a bit back and forth.

M0Rf30 commented 1 year ago

Why are you removing &dsi_phy0? I think that should stay?

Also we should squash this in the next rebase so it just becomes nice patches on top of mainline instead of a bit back and forth.

dsi_phy0 doesn't exist anymore. Now dsi0_phy (phy@1a94400) is used

Ok for the squash on next rebase

M0Rf30 commented 1 year ago

Another "removed ?!" label is:

&atc_leds {
    status = "okay";
};

didn't find an appropriate replacement (leds@1243)

z3ntu commented 1 year ago

qcom,leds-atc driver should go upstream though. I didn't include it upstream since it's not supported there.

ping @SirSireesh

SirSireesh commented 1 year ago

qcom,leds-atc is not upstreamable, it does things which docs say the driver shouldn't do. Basically the ATC LEDs support changing frequency of blinking, which is currently set using the brightness slider. Its been a long time since I looked at it, so I don't remember if there was an alternate API that this driver could use.

z3ntu commented 1 year ago

Basically the ATC LEDs support changing frequency of blinking, which is currently set using the brightness slider. Its been a long time since I looked at it, so I don't remember if there was an alternate API that this driver could use.

There's pattern api for leds upstream, that should be appropriate for this?

M0Rf30 commented 1 year ago

Hi, is this still valid for the new 6.3 branch? Without these edits the 6.3 can't work (dsi_phy0 -> dsi0_phy for example)

alikates commented 1 year ago

Probably no, also @Kiciuk has commonized xiaomi devices so a lot of stuff will change. But please don't use the 6.3 branch yet, I'm still working on it and a lot of stuff is broken.

alikates commented 1 year ago

Well, I'm going to apply it but I have to change some stuff because now there's the xiaomi common dtsi.

M0Rf30 commented 1 year ago

Now that is merged in 6.3.0 I close this