msm8953-mainline / linux

Linux mainline kernel with WIP patches for msm8953 devices
Other
115 stars 59 forks source link

dts: qcom: msm8953-xiaomi-tissot: Add some new features #90

Closed JIaxyga closed 1 year ago

JIaxyga commented 1 year ago
fekz115 commented 1 year ago

You added new drivers. Are they already enabled in your config?

JIaxyga commented 1 year ago

You added new drivers. Are they already enabled in your config?

It doesn't matter. It still doesn't work correctly.

M0Rf30 commented 1 year ago

Please edit the gpio-keys block according to this https://github.com/msm8953-mainline/linux/pull/91#discussion_r1177628976

JIaxyga commented 1 year ago

Please edit the gpio-keys block according to this #91 (comment)

Tissot along with the hall sensor was upstream in this look. Upstream maintainers will make the necessary changes themselves

JIaxyga commented 1 year ago

Please edit the gpio-keys block according to this #91 (comment)

Tissot along with the hall sensor was upstream in this look. Upstream maintainers will make the necessary changes themselves

There is no point in making changes here as it will make conflicts in future

JIaxyga commented 1 year ago

Please edit the gpio-keys block according to this #91 (comment)

Tissot along with the hall sensor was upstream in this look. Upstream maintainers will make the necessary changes themselves

There is no point in making changes here as it will make conflicts in future

I suggest waiting for the moment when the upstream linking is successful

alikates commented 1 year ago

One small issue to fix before merging. Can you change the commit message for the config changes to the format that's been used previously? (arm64: config: ...)

JIaxyga commented 1 year ago

One small issue to fix before merging. Can you change the commit message for the config changes to the format that's been used previously? (arm64: config: ...)

Oooooops xD