search

msm8974-mainline / linux

Mainline Kernel fork for MSM8x74 devices
https://www.postmarketos.org
Other
19 stars 23 forks source link

ARM: dts: qcom: msm8974-sony-{castor,leo}: put common parts in separate dtsi #13

Closed TheOrangeCat closed 8 months ago

TheOrangeCat commented 8 months ago

I've put some common parts of castor and leo into a common qcom-msm8974pro-sony-xperia-shinano.dtsi, similar to qcom-msm8974-sony-xperia-rhine.dtsi. Right now I only coalesced the exact same parts, but it seems like some other parts are functionally the same. I didn't add those as I am not 100% sure they are the same. This could be quite convenient for adding other shinano devices like aries.

This needs to be checked, however.

z3ntu commented 8 months ago

I've sent some cleanup patches upstream for castor a few days ago https://lore.kernel.org/linux-arm-msm/20240306-castor-changes-v1-0-2286eaf85fff@z3ntu.xyz/T/ and also actually did the changes you did on top of those a few days ago - still have to send those upstream after a bit of testing.

I'll double check my changes against yours also

TheOrangeCat commented 8 months ago

By the way, should I also throw in a preliminary dts for aries? It's almost the exact same as leo except for the model, compatible and charging current limits, although I haven't tested it as I'm struggling to get envkernel to cooperate.

z3ntu commented 8 months ago

Sent my version upstream now including sony-leo additions: https://lore.kernel.org/linux-arm-msm/20240310-shinano-common-v1-0-d64cd322ebca@z3ntu.xyz/T/

You can base on top of that (will also push soon - hopefully today - as qcom-msm8974-6.8.y).

Keep in mind, the common parts represent what I found to be common between castor and leo, I didn't take a look at other shinano devices, so it's quite possible that you'll need to move some parts from shinano-common to castor and leo separately if they're not present or quite different on your shinano device.

TheOrangeCat commented 8 months ago

I checked aries, it boots just fine (even usb networking and most likely wifi, just don't have the firmware) with a very close-to-leo dts on my branch, so it'll most likely run fine with your common dtsi just fine. I'll add the dts for it based on the new branch once you push it.

z3ntu commented 8 months ago

For now I've pushed it to qcom-msm8974-6.8-wip, you can use that if you want.