search

msm8974-mainline / linux

Mainline Kernel fork for MSM8x74 devices
https://www.postmarketos.org
Other
19 stars 21 forks source link

ARM: dts: qcom-msm8974pro-oneplus-bacon: Add NFC node #17

Open rhjdvsgsgks opened 3 months ago

rhjdvsgsgks commented 3 months ago

in downstream driver. they are also using IRQ_TYPE_LEVEL_HIGH for irq. should i swich back to it? or keep using IRQ_TYPE_EDGE_FALLING just like what bq24196_charger have? the device can work in both modes

https://github.com/LineageOS/android_kernel_oneplus_msm8974/blob/84bb8fee677f3d6b606e7c21efd34571cc4c818d/drivers/nfc/pn544-oppo_find7op.c#L536

z3ntu commented 3 months ago

Super cool you got it working! I can test it also, I have a OnePlus One too

For the commit, could you please set your git author to something that resembles a name & normal email address? And then add a Signed-off-by footer to the commit message please https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

z3ntu commented 3 months ago

Just tested this on my device, and it works! :tada:

It's sometimes a bit picky with where exactly to place the NFC tag but it doesn't seem like it's something that could be changed in the dts anyways. I'd expect stock Android to not behave much different.