search

msmasnadi / OPGEEv4

OPGEE v4
Other
10 stars 4 forks source link

Attempt to fix broken OPGEE dependencies #3

Closed bcspragu closed 1 month ago

bcspragu commented 1 year ago

This PR updates some Conda/pip dependencies to fix a versioning mismatch, see [1], [2] for more details.

Note: I haven't run the tests yet against these versions of dependencies, so I'll leave this as a draft until I do.

[1] https://github.com/CalebBell/thermo/issues/135 [2] https://github.com/Stanford-EAO/OPGEEv4/issues/2

rjplevin commented 1 year ago

I've also fixed the dependency issues, but the result fails our tests as some numerical results are now different. Working on it...

bcspragu commented 1 year ago

Indeed, I just ran the tests and saw the same behavior. Looks like most differ by +/- 1%, if those are acceptable, I can probably just find and replace all those results quickly with a string manipulation. Happy to do that if it's useful

EDIT: Chatted elsewhere, will hold off for now

rjplevin commented 1 month ago

Closed as obsolete.