Closed lloyd-rmi closed 2 months ago
Hi lloyd-rmi, Thank you for the feedback. I’ve added the units to all the output file names for clarity. The carbon intensity is now labeled in g/MJ, emissions in tonnes/day, energy in MMBtu/day, and gases in tonnes/day. The streams file includes units within the file itself.
Two issues with this approach:
For example:
import re
units = str(Emissions.units()) # => 'metric_ton / day'
filename = "emissions-" + re.sub('\s*/\s*', "_per_", units) + ".csv" # => 'emissions-metric_ton_per_day.csv'
The desire for this issue was to have the units tied to each column output within each file, rather than the file as a whole. Would request that we make that change so re-opening the issue.
Agreed that avoiding hard coded units would be a less brittle approach as well.
It is difficult to always track what units the output data is in. Having them explicitly added into the name of each column would make it simple for us to always know what numbers we are dealing with.