search

msmbuilder / msmbuilder-legacy

Legacy release of MSMBuilder
http://msmbuilder.org
GNU General Public License v2.0
25 stars 28 forks source link

[WIP] Reversible eigenvector bug fix for issue #412 #416

Closed schwancr closed 10 years ago

schwancr commented 10 years ago

The reversible eigenvector function was not calculating the right eigenvectors. I fixed this and also added the option to normalize the eigenvectors.

I also added a test to check for these issues as well as check the normalization.

kyleabeauchamp commented 10 years ago

So I wonder if a better API would be to have reversible_eigenvectors always return both left and right eigenvectors, as you get them both essentially "for free". That might be cleaner than lots of if then branching inside the function. Just a crazy idea for you guys to discuss...

schwancr commented 10 years ago

yea that's not a bad idea. though calculating the right eigenvectors from the left is trivial

rmcgibbo commented 10 years ago

+1 to merge.

schwancr commented 10 years ago

I think this is good now