Joss Review Suggestions

cxhernandez commented 7 years ago

re: #77

Installation:

[x] Support conda install with python 3.6.
[x] Specify version requirements (if applicable) for dependencies. The Fs-peptide notebook gets angry at pandas 0.16 (a few years behind the times) for the tICA cell. Alternatively, suggest that users update to most recent version for these dependencies if they are using an existing python 3.4 build.

Example usage:

[x] Describe a possible use case for the chord diagram. It seems a bit disconnected from the rest of the tools, so adding an example (perhaps to some visualization of FS-peptide structure) could really tie things together.

Community guidelines:

[x] Add a sentence to the "Development" section of your README directing potential contributors to the link you have already included.
[x] Include a preferred method of contact for users seeking support.

Version:

mpharrigan commented 7 years ago

Cool!

msultan commented 7 years ago

Seems fine to me but as do you need to add msmbdata as a dependency as well since you removed the code that gets the data?

cxhernandez commented 7 years ago

MSMBuilder requires it already (as evidenced by the tests working 😄 )

msmbuilder / msmexplorer