search

msmitherdc / libkml

Automatically exported from code.google.com/p/libkml
Other
0 stars 0 forks source link

Testb2a_hex test fails in VCExpress 2010 #151

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Compile the test suite using Visual Studio C++ 2010
2. Execute run_tests.bat

What is the expected output? What do you see instead?

All the tests passed apart from the Testb2a_hex test.

What version of the product are you using? On what operating system?

Downloaded the libkml-1.2.0.tar.gz from the downloads page. Ran under Windows 7.

Did you run the unit test suite that comes with the project? Did all tests pass?

See above.

Please provide any additional information below.

I managed to make the test pass by changing line 36 of 
kml\base\string_util_test.cc from:

  static char a[2];

to:

  static char a[3] = { 0 };

I'm assuming that this allowed for the returned string to be null terminated, 
but C++ isn't really my field, sorry. After changing this line and recompiling 
all the tests passed.

Original issue reported on code.google.com by Sam.Cr...@gmail.com on 17 Jun 2010 at 9:03