search

msmitherdc / libkml

Automatically exported from code.google.com/p/libkml
Other
0 stars 0 forks source link

[PATCH] fix compilation on GNU/Hurd #183

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Attached there is a patch (done against SVN r864) to compile libkml on GNU/Hurd.

* configure.ac:
  set PLATFORM as "linux" for GNU-based platforms (thus including also
  Debian's GNU/kFreeBSD), to use the correct paths for Java includes
* third_party/googletest-r108/src/gtest-filepath.cc:
  fix compilation of this older google-test copy, by defining PATH_MAX
  if not defined (like happens on GNU/Hurd); this is just a "quick fix",
  and upgrading the google-test copy to a more recent version will
  fix the issue as well.

Original issue reported on code.google.com by toscano....@tiscali.it on 5 Oct 2012 at 1:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Is the PATH_MAX declaration really the appropriate fix on HURD?  I'm not keen 
to try and present it to the gtest upstream owners as is. 

Also, I'm trying to understand why it is necessary that the HURD get treated as 
PLATFORM=linux vs. PLATFORM=unknown.  Is it primariliy for the Java and Python 
build pointers?

Original comment by fwarmerdam@gmail.com on 30 Jan 2013 at 11:08

GoogleCodeExporter commented 9 years ago 
> Is the PATH_MAX declaration really the appropriate fix on HURD?

It's similar to what the gtest developers did, so this patch should stay local 
for libkml until the next update of the gtest copy.

> Also, I'm trying to understand why it is necessary that the HURD get treated 
as PLATFORM=linux vs. PLATFORM=unknown.  Is it primariliy for the Java and 
Python build pointers?

Yes, basically. I don't know how to eventually replace the two PLATFORM usages 
with cross-platform ways (to get the Python library and the Java includes), 
sorry. (But I can eventually test patches.)

Original comment by toscano....@tiscali.it on 30 Jan 2013 at 11:33

GoogleCodeExporter commented 9 years ago 
I'm ok with this.  I'm pursuing applying the patch...

Original comment by warmerdam@google.com on 2 Apr 2013 at 11:35

GoogleCodeExporter commented 9 years ago

Original comment by fwarmerdam@gmail.com on 2 Apr 2013 at 11:38

GoogleCodeExporter commented 9 years ago 
Backed out internal patch pending a contribution assignment from the 
contributor.

Original comment by fwarmerdam@gmail.com on 16 Apr 2013 at 8:30

GoogleCodeExporter commented 9 years ago 
could this patch be applied?

Original comment by rasha...@gmail.com on 4 Apr 2015 at 9:05