Unified matsim assignment for direct coupling and mito - Githubissues

msmobility / silo

SILO Model Java Code

GNU General Public License v2.0

18 stars 26 forks source link

Unified matsim assignment for direct coupling and mito #232

Closed nkuehnel closed 4 years ago

nkuehnel commented 4 years ago

remove mito transport model. mito now serves as a demand generator, the actual assignment is done within silo using the same infrastructure as the direct coupling. This removes duplicated code. The matsim transport model now requires a matsim scenario assembler (implemented for mito and for the simple direct coupling).

This approach allows us:

to maintain code better as we do not have to maintain mito and matsim transport model (i.e. for travel time updates)
pass a consistent config to the whole silo mito matsim chain to be able to configure the assignment through the config
add matsim contribs like noise or emissions from within silo and use the respective output data in silo

todo[bot] commented 4 years ago

Add some switch here like "autoGenerateSimplePlans" or similar...

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/extensions/matsim2silo/src/main/java/de/tum/bgu/msm/matsim/SimpleMatsimScenarioAssembler.java#L113-L118

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

todo[bot] commented 4 years ago

Potentially change later

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/extensions/matsim2silo/src/main/java/de/tum/bgu/msm/matsim/SimpleMatsimScenarioAssembler.java#L115-L120

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

todo[bot] commented 4 years ago

Potentially change later

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/extensions/matsim2silo/src/main/java/de/tum/bgu/msm/matsim/SimpleMatsimScenarioAssembler.java#L117-L122

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

todo[bot] commented 4 years ago

Potentially change later

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/extensions/matsim2silo/src/main/java/de/tum/bgu/msm/matsim/SimpleMatsimScenarioAssembler.java#L120-L125

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

todo[bot] commented 4 years ago

Potentially change later

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/extensions/matsim2silo/src/main/java/de/tum/bgu/msm/matsim/SimpleMatsimScenarioAssembler.java#L122-L127

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

todo[bot] commented 4 years ago

Add some switch here like "autoGenerateSimplePlans" or similar...

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/extensions/matsim2silo/src/main/java/de/tum/bgu/msm/matsim/SimpleMatsimScenarioAssembler.java#L149-L154

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

todo[bot] commented 4 years ago

reconsider CreateCarOwnershipModel in Kagawa

https://github.com/msmobility/silo/blob/c2e94cef474a8650b8db81b7ee1791cdbae022d0/useCases/kagawa/src/main/java/de/tum/bgu/msm/run/ModelBuilderTak.java#L76-L81

This comment was generated by todo based on a `TODO` comment in c2e94cef474a8650b8db81b7ee1791cdbae022d0 in #232. cc @msmobility.

nkuehnel commented 4 years ago

This is also a step towards to fixing #180