search

msneddon / nfsim

A general-purpose, stochastic, biochemical reaction simulator for large reaction networks
MIT License
17 stars 18 forks source link

Clang compatibility #19

Closed jesperromers closed 7 years ago

jesperromers commented 7 years ago

Pointer to int comparison was not allowed by clang. Also returning "false" instead of quitting by "exit(1)" was not allowed by clang. Both issues fixed and tested under clang and gcc under os x.

msneddon commented 7 years ago

Sorry- forgot to mention to you that I'd like to keep PRs going to the dev branch for now. Can you close and reopen this against dev? Thanks.

This repo actually needs a little bit more branch cleanup- basically tagging releases in github so we can track the latest development on master. I'll do this sometime early next week since you're planning to work more heavily on the code.

jesperromers commented 7 years ago

Sure will do!

jesperromers commented 7 years ago

Done. Best,

Jesper

On Fri, Mar 3, 2017 at 6:35 PM, Michael Sneddon notifications@github.com wrote:

Sorry- forgot to mention to you that I'd like to keep PRs going to the dev branch for now. Can you close and reopen this against dev? Thanks.

This repo actually needs a little bit more branch cleanup- basically tagging releases in github so we can track the latest development on master. I'll do this sometime early next week since you're planning to work more heavily on the code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/msneddon/nfsim/pull/19#issuecomment-284018911, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrS_mpn6CgamSKFI4lyWTPu_wuXElNUks5riE91gaJpZM4MSVTt .