Maven logging for maven-assembly-plugin does not look good

msnijder30 / openapi-diff

Utility for comparing two OpenAPI specifications.

Apache License 2.0

0 stars 0 forks source link

Maven logging for maven-assembly-plugin does not look good #3

Open rmuller opened 5 years ago

rmuller commented 5 years ago

A lot of warnings about skipped directories/files. This is very undesirable.

As discussed, it is better to use the Apache Maven Shade Plugin.

[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ openapi-diff ---
[INFO] META-INF/MANIFEST.MF already added, skipping
[INFO] META-INF/ already added, skipping
[INFO] META-INF/maven/ already added, skipping
[INFO] io/ already added, skipping
[INFO] io/swagger/ already added, skipping
[INFO] io/swagger/v3/ already added, skipping

msnijder30 commented 5 years ago

Can you verify it works as expected before closing since I'm not super familiar with the maven-shade-plugin?

Also the following error is showing: [WARNING] Discovered module-info.class. Shading will break its strong encapsulation.

Am I correct in saying that this is not an issue since that's a Java 9 feature and we are using Java 8 to compile everything?

rmuller commented 5 years ago

Also the following error is showing: [WARNING] Discovered module-info.class. Shading will break its strong encapsulation.

Yes, for Java 8, this can be ignored.