msoedov / hacker-slides

A small UI for building presentation slides from markdown markup
https://murmuring-sierra-54081.herokuapp.com/
MIT License
348 stars 67 forks source link

Preview vs Present #47

Open SGStino opened 5 years ago

SGStino commented 5 years ago

There seems to be an issue where the server side code renders markdown differently than the client side javascript code?

it renders the markdown with the html <span class="hljs-built_in">...</span> readable.

Markdown:

```sh
mkdir my-repository
cd my-repository
git init

Present&Preview:

<pre><code class="lang-sh hljs bash">mkdir my-repository
&lt;span class=<span class="hljs-string">"hljs-built_in"</span>&gt;<span class="hljs-built_in">cd</span>&lt;/span&gt; my-repository
git init
</code></pre>

Preview generated & updated after editing

<pre><code class="lang-sh hljs bash">mkdir my-repository
<span class="hljs-built_in"><span class="hljs-built_in">cd</span></span> my-repository
git init
</code></pre>
msoedov commented 5 years ago

Hi @SGStino, thank you for submitting the issue. Can share more details about how to reproduce?

screen shot 2019-01-12 at 19 19 52
SGStino commented 5 years ago

Yes, that's the preview, That works perfectly, but if you would now hit Present, you would get to see the html tag. around the cd

I'm using the latest docker image.

groteck commented 5 years ago

same here

msoedov commented 5 years ago

I have updated reveal to 3.8. That might fix this issue

msoedov commented 5 years ago

I was not able to reproduce it initially and I don't see any issues with #50 changes. Will merge and update docker today