msoeken / kitty

C++ truth table library
MIT License
50 stars 77 forks source link

Adding support for Windows build #51

Closed whaaswijk closed 6 years ago

whaaswijk commented 6 years ago

Kitty now uses the __builtin_popcount function which is not available on Windows. This fix adds a batch file to generate a Visual Studio solution for kitty and defines a macro to use the __popcnt function which is defined on (many) Windows platforms.

msoeken commented 6 years ago

Thanks for the fix. I think the macros are sufficient to fix it. I'd rather not have the vsgen.bat file and let the user set the -g flag herself or himself.

whaaswijk commented 6 years ago

Yes, fair enough, the batch file was more for my own repeated builds.

msoeken commented 6 years ago

Maybe we could use appveyor.com for Windows continuous integration.

Could you remove the file from the PR. Then I can merge it better.

whaaswijk commented 6 years ago

Batch file removed. And appveyor.com seems like a good option, looks like they have a free tier for open source projects.

msoeken commented 6 years ago

Thanks!