search

msokk / electron-render-service

Microservice for rendering PDF/PNG/JPEG from HTML with Electron
MIT License
102 stars 28 forks source link

Set Electron version via --build-args #78

Closed p3k closed 5 years ago

p3k commented 5 years ago

This pull request applies the following changes

  1. Electron version can be customized on build using --build-arg electron_version=x.y.z argument
  2. Installs NodeJS without insecure execution of arbitrary remote file in root context
  3. Split up chained Dockerfile commands into smaller steps for improved incremental build
msokk commented 5 years ago

Thanks, way back I had some commands lumped together to reduce layers file size, I don't if that's the case now anymore, altough the whole image is big anyway, so readability matters more.

Can you rebase it? It has some conflicts

p3k commented 5 years ago

Thanks, way back I had some commands lumped together to reduce layers file size, I don't if that's the case now anymore, altough the whole image is big anyway, so readability matters more.

ok, i am not sure about what’s the best practice here with docker; a plethora of layers just helped me a lot during rebuilding… just let me know if you still prefer it lumped together.

Can you rebase it? It has some conflicts

um, i see the travis ci check has faild but otherwise it says This branch has no conflicts with the base branch…

p3k commented 5 years ago

re layers i read docker’s documentation about best practices for docker files more thouroughly and applied those in pr #80, reverting some of my changes.