fix: regression in docker file according to best practices

msokk / electron-render-service

Microservice for rendering PDF/PNG/JPEG from HTML with Electron

MIT License

102 stars 28 forks source link

fix: regression in docker file according to best practices #80

Closed p3k closed 5 years ago

p3k commented 5 years ago

see https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run

msokk commented 5 years ago

Thanks, I'll try to get to bottom with build failure this weekend.

msokk commented 5 years ago

I swapped out testing framework, but it looks like that PDF rendering has some race conditions in Electron v4 Linux, in some cases valid blank PDF is rendered.