msokk / electron-render-service

Microservice for rendering PDF/PNG/JPEG from HTML with Electron
MIT License
102 stars 31 forks source link

An in-range update of electron is breaking the build 🚨 #81

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency electron was updated from 4.0.6 to 4.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

electron is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/msokk/electron-render-service/builds/501821179?utm_source=github_status&utm_medium=notification)).

Release Notes for electron v4.0.7

Release Notes for v4.0.7

Fixes

  • Fixed defaultId not taking affect when set to 0 and no "cancel" button was present on macOS. #17151
  • Fixed process.versions.chrome reporting the wrong patch version. #17218
  • Fixed webContents.print() not working correctly. #17116
  • Fixed a bug when retrieving security scoped bookmarks in ShowOpenDialog and ShowSaveDialog. #17176
FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 4.0.6 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.