updated Electron to 4.0.5

msokk / electron-render-service

Microservice for rendering PDF/PNG/JPEG from HTML with Electron

MIT License

102 stars 31 forks source link

updated Electron to 4.0.5 #85

Open cyril23 opened 5 years ago

cyril23 commented 5 years ago

I have bumped Electron to 4.0.5, because I was getting error signal 11 SEGV_MAPERR with the old version which will not be fixed due to old Electron version: https://github.com/electron/electron/issues/9236

It runs fine so far, since 4 weeks and about 200 PDFs / day.

edit: I use HTML to PDF only (no PNG or whatever)

msokk commented 5 years ago

Master is on 4.0.6, but I haven't had time to release it as v4 renders blank PDF-s on higher loads. Maybe it is an issue with test setup.

cyril23 commented 5 years ago

Master is on 4.0.6, but I haven't had time to release it as v4 renders blank PDF-s on higher loads. Maybe it is an issue with test setup.

How to check if PDFs with blank pages have been created?

Does it still return 200 OK?
What's the size of those PDFs? I would like to check my PDF exports.

edit: have you opened up an issue for this?

msokk commented 5 years ago

@cyril23 The tests fail, I haven't created an issue, it returns 695 bytes big valid blank PDF file, you can check it like this - https://github.com/msokk/electron-render-service/blob/master/__tests__/stability.js#L30, have to slice the beginning bytes out as that bit contains a timestamp.