search

msoon / PyMonsoon

Monsoon Power Monitor Python Library
MIT License
55 stars 23 forks source link

HVPM: Add fillAllStatusPacket #3

Closed ccfries closed 7 years ago

ccfries commented 7 years ago

Fill more contents in the status packet on request, since a client might find the current status useful.

TODO: are there opcodes to read the temperature, current limts, USB passthru mode?

TODO: I see fillStatusPacket getting used elsewhere, and I wasn't sure if we should just keep the single routine for reading the whole thing.

ccfries commented 7 years ago

This patch isn't very useful as-is, but getting the full status is something I'd find useful.

Mbrinker commented 7 years ago

Filling the entire status packet like this is the intended final purpose of the fillStatusPacket function. The only reason it's so empty right now is because I was only filling up the bare minimum necessary to get measurements functional.

There shouldn't be any problem just merging this into the existing fillStatusPacket