Bugfix/double quoted imports

msoucy / dproto

D Protocol Buffer mixins to create structures at compile time

Boost Software License 1.0

37 stars 16 forks source link

Bugfix/double quoted imports #39

Closed cporter closed 9 years ago

cporter commented 9 years ago

Addresses two problems:

protobuf imports were being mistranslated in to D code. Specifically

import "foo.proto"

was rendered as

ProtocolBuffer!""foo.proto""

protobuf imports pointing to paths crashed

msoucy commented 9 years ago

I'm trying to think of a way to add a unit test for this...I'd love to have a good test case somewhere just to catch things like this. Otherwise, looks great!

cporter commented 9 years ago

The added test includes paths in the imports. Pre-patch they would fail at compile time.

msoucy commented 9 years ago

Ah, apologies. I misread one commit as the entire thing and was a bit confused.