search

msoucy / dproto

D Protocol Buffer mixins to create structures at compile time
Boost Software License 1.0
37 stars 16 forks source link

Fixed a name confliction error #50

Closed elvisxzhou closed 9 years ago

elvisxzhou commented 9 years ago

Field names of message conflict with internal variable names which are used when defining serialize/deserialize functions.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.06%) to 53.79% when pulling 54de3231a6ffe963a2cf2cb90b22e4b05b527ebc on elvisxzhou:master into 8760a748cb7eab790ce113d222b2f760b86cd191 on msoucy:master.

msoucy commented 9 years ago

I was actually expecting the first issues to be in the _isset variables - since you're making this request, could you do those as well? Otherwise, thank you! :+1:

elvisxzhou commented 9 years ago

Don't get it, seems no problem with _isset variables here.

msoucy commented 9 years ago

Alright then, this looks great. Thank you!