Closed adehad closed 2 years ago
@msoulier I've also addressed the lint problems on master that were causing the CI to fail in a separate commit, feel free to cherry pick that commit if you don't want the flake8 changes.
I have to admit that I'm not really big on enforcing linters running, as long as we have decent code coverage from the test suite. I really don't care much about style guides, I just want correct code.
Gotcha, sorry for the noise.
Feel free to remove /comment out:
This way you can still get the benefit of seeing if the tests pass in a merge request but not have any failures reported due to the linters.
Should be merged after #129
@msoulier there are quite a few errors relating to using
*
imports, I tried defining the__all__
variable but I don't think that helped, do you have a preference for how to handle this? https://github.com/msoulier/tftpy/runs/3983425893?check_suite_focus=true#step:5:64I tried making all files import only what they need