search

msoulier / tftpy

Pure Python TFTP library
http://tftpy.sf.net
MIT License
172 stars 120 forks source link

Python 3 compatibility #94

Closed AndreasDa closed 6 years ago

AndreasDa commented 6 years ago

As the other pull request concerning python3 compatibility is quite outdated, I thought I would start a new one. This is based on the current master branch. I inserted and tested the changes necessary to make my simple server and client example work without problems in both python2 and python3. I did not check any edge cases.

msoulier commented 6 years ago

Running tests with python 2.7.13, they all pass.

Running tests with python 3.5.3, 10 fail.

msoulier commented 6 years ago

I've started a private branch off of yours to see if I can fix the remaining testcases.

msoulier commented 6 years ago

I am rejecting this pull request, and the other one for python3, but I made my own python3 branch off of this one and I've been slowly fixing the failing testcases. I hope to have something working soon.