mspass-team / mspass

Massive Parallel Analysis System for Seismologists
https://mspass.org
BSD 3-Clause "New" or "Revised" License
28 stars 11 forks source link

initial commit for adding the p wave pick function #517

Open JiaoMaWHU opened 4 months ago

JiaoMaWHU commented 4 months ago

Summary

Testing

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (91addbb) to head (1351480).

:exclamation: Current head 1351480 differs from pull request most recent head 6c8425c

Please upload reports for the commit 6c8425c to get more accurate results.

Files Patch % Lines
python/mspasspy/algorithms/ml/arrival.py 96.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #517 +/- ## ========================================== + Coverage 54.54% 55.30% +0.75% ========================================== Files 146 145 -1 Lines 22371 22590 +219 Branches 1336 0 -1336 ========================================== + Hits 12203 12493 +290 - Misses 9828 10097 +269 + Partials 340 0 -340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JiaoMaWHU commented 4 months ago

the next step is to consider two options:

  1. return all picks of a waveform
  2. return the most possible pick inside a window
JiaoMaWHU commented 2 months ago

to fix the docker issue, we can try

  1. exclude cuda library from seisbenc
  2. clean up cache: https://github.com/mspass-team/mspass/actions/caches
  3. try removing https://github.com/mspass-team/mspass/blob/7f959aa19e4fc3393bced4061067032df7b6db95/.github/workflows/docker-publish.yml#L108C1-L109C59
JiaoMaWHU commented 2 months ago

Hi @wangyinz please take a look at this pr, it's ready for review. Thank you.