search

mspass-team / mspass

Massive Parallel Analysis System for Seismologists
https://mspass.org
BSD 3-Clause "New" or "Revised" License
28 stars 11 forks source link

Fixing issues with conda build #536

Closed wangyinz closed 1 month ago

wangyinz commented 1 month ago

This branch will build all conda packages within the container. This should simplify the process and avoid some unknown issues with the versioning of the conda package the master branch currently have.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.57%. Comparing base (b56af55) to head (04b0577).

:exclamation: Current head 04b0577 differs from pull request most recent head 83207f2. Consider uploading reports for the commit 83207f2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #536 +/- ## ========================================== + Coverage 54.54% 54.57% +0.03% ========================================== Files 146 146 Lines 22358 22358 Branches 1336 1336 ========================================== + Hits 12195 12202 +7 + Misses 9823 9816 -7 Partials 340 340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wangyinz commented 1 month ago

Turns out the versioning didn't work because of the default behavior of the checkout step. It only checkout the current commit from the repo, which breaks the assumption of the versioning mechanism where we need to use the tags to identify the number. There are more discussions here: https://github.com/actions/checkout/issues/217